fix: Enable HTTP proxy support by removing sudo from curl commands in quickstart/install-deps.sh
#370
Conversation
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
|
HI @nerdalert |
There was a problem hiding this comment.
LGTM, thanks for the enhancement. Btw, wanted to give you a heads up we are migrating to a decomposed deployer here https://github.com/llm-d-incubation/llm-d-infra in the next few days in a release. Don't hesitate to ping here or in Slack with any questions/concerns. Ty.
Thanks @nerdalert Would you help invite me to join the Slack group for llm-d? My email is yankay.com@gmail.com |
|
@yankay great! Grab the inviter link here https://github.com/llm-d/llm-d?tab=readme-ov-file#contribute we also have a Thursday community call in the calendar on the same page. Chat soon. |
Problem
When using sudo curl in the installation script, HTTP proxy environment variables (such as http_proxy, https_proxy, no_proxy) are not inherited by the curl process running under sudo. This causes network requests to fail in proxy environments.
Solution
Modified the yq installation process in quickstart/install-deps.sh:
• Replaced
sudo curl -sLo /usr/local/bin/yqwithcurl -sLo yqfollowed bysudo mv yq /usr/local/bin/yq• Added a verification step to ensure yq is correctly installed (to address potential issues like an incorrect version being installed).