Skip to content

Detect minikube context for uninstall #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Detect minikube context for uninstall #278

merged 1 commit into from
Jun 23, 2025

Conversation

nerdalert
Copy link
Member

  • Simplifies minikube uninstall for hostPath pv removal.

@tumido tumido added the quickstart Related to quickstarts label May 21, 2025
@nerdalert nerdalert force-pushed the minikube-uninstall branch from 5730a41 to 57ef1a0 Compare May 26, 2025 01:30
Gregory-Pereira
Gregory-Pereira previously approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Gregory-Pereira Gregory-Pereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm great enhancement

@nerdalert nerdalert force-pushed the minikube-uninstall branch 2 times, most recently from e7f4e61 to 9bc2f70 Compare June 23, 2025 20:30
@nerdalert
Detect minikube context for uninstall
67b8ede 
Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert nerdalert force-pushed the minikube-uninstall branch from 9bc2f70 to 67b8ede Compare June 23, 2025 20:50
@nerdalert nerdalert merged commit 13794f2 into llm-d:main Jun 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregory-Pereira Gregory-Pereira Gregory-Pereira left review comments

Assignees
No one assigned
Labels
quickstart Related to quickstarts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nerdalert @Gregory-Pereira @tumido