bootstrap: do not fail if no user or group defined #1223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1223 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 64 64
Lines 11859 11859
=======================================
Hits 10267 10267
Misses 1592 1592 🚀 New features to boost your workflow:
|
13 tasks
nitnelave
approved these changes
Jul 21, 2025
14b083c to
3427f12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where no file is found should be handled gracefully. And with DO_CLEANUP=true, it means we want to cleanup all users and groups.
This was tested in this NixOS PR NixOS/nixpkgs#425923
Pushing my luck on the fast review :P