Litecoin Core 0.16.2 final changes #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signatures using segregated witness commit to the amount being spent, so that value must be passed into signrawtransactionwithkey and signrawtransactionwithwallet. This ensures an error is issued if that doesn't happen, rather than just assuming the value is 0 and producing a signature that is almost certainly invalid. Github-Pull: bitcoin#13547 Rebased-From: a3b065b
Github-Pull: bitcoin#13547 Rebased-From: 685d1d8
…or type, add test cases covering bitcoinconsensus error codes Github-Pull: bitcoin#13655 Rebased-From: 417b6c1
Tree-SHA512: fb7208356134322f3515c682ac7349eddb1ff54094abe397c94acb7e931b42265aca6b716eba072f79ebdb4a69ea87a5e40b6c4a48571db5b7b095ead45456ef
… set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes 1cdbea7 bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes (Thomas Kerin) Pull request description: Backport of bitcoin#13655 to 0.16 Tree-SHA512: b62e185f2aa957f09255090e59f96c039f47a5623d68b6fef8d1dd831c6d3135b039be5cfad0f823687ff2a5143d24e34bd83fefcc9ba5b68f43054cbd9d909d
see: .../src/init.cpp#L1063 Github-Pull: bitcoin#13844 Rebased-From: 312ff01
…n amount is needed but missing 212ef1f [tests] Check signrawtransaction* errors on missing prevtx info (Anthony Towns) 1825e37 Error on missing amount in signrawtransaction* (Anthony Towns) Pull request description: Backport of bitcoin#13547 to 0.16 Tree-SHA512: 7a660023b6948632a1f949443c18fa45add75ec8c36df1ebbaccd181dd1560c1bef460f061f8dab36b6a5df295eb4967effaa2cf55ea06b41d8f7562842a39ec
11b9dbb -prune option -help output aligned with code (Hennadii Stepanov) Pull request description: Backports bitcoin#13844 to the 0.16 branch. Tree-SHA512: 84cac57ca3b1ef34892e73f131b5f3cc50d3f9e268a4123092cf6cdf519fc20616b5b084f9e9343505c15a2cf663a2c94d18c4587bcb7c261cbe32eeac8afe9b
kcw-grunt
reviewed
Aug 26, 2018
|
lgtm; tACK all 0.16.2 changes too |
|
Thank you guys! |
|
@kcw-grunt Yeah, alignment of the rest of the 0.16 branch changes. Minor documentation update, bug fixes for signrawtransaction/consensus library error handling and extension of tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug fixes and expansion of QA testing.
Upon review and no issues detected, 0.16.2 final is ready to be tagged for release.