Skip to content

Conversation

Velosofy
Copy link
Contributor

Closes #423

@Guldoman
Copy link
Member

Does this apply to directories too?

@Velosofy
Copy link
Contributor Author

Does this apply to directories too?

It does not, It actually didn't come to mind

@adamharrison
Copy link
Member

As discussed on discord; may make more sense to use HKCU or HKLM, depending on how they install it. Will leave this open until you're ready with that.

@Velosofy
Copy link
Contributor Author

This now applies to both directory and file

It also able to "Open with Lite XL" within a directory
image

@adamharrison
Copy link
Member

Tested; it works. The actual install process leaves me with a broken executable, but that's not this PR's problem. Works totally fine for me. Merging.

@adamharrison adamharrison merged commit 89c0c76 into lite-xl:master Jan 20, 2023
@blazer2k1
Copy link

It would be nice to have this on the portable version as well in a .reg file.

@Guldoman
Copy link
Member

I don't think it would work as the keys would need to refer to the location of the executable, which is not known in the portable case.

@Velosofy
Copy link
Contributor Author

A bat script might be able to do the job, but it's a hassle as you need to manually install/uninstall the context menu integration

@empz
Copy link

empz commented Aug 30, 2023

This is not working for me. I installed 2.1.1 via Chocolatey and I don't have the option.
https://community.chocolatey.org/packages/lite-xl

Could it be because this is on Windows Server 2022 Standard?

@Guldoman
Copy link
Member

The context menu entry is added via our installer.
It looks like the Chocolatey package is not using the installer, but it's using our portable zips, so it would need to "manually" add the register keys.

@empz
Copy link

empz commented Aug 30, 2023

The context menu entry is added via our installer. It looks like the Chocolatey package is not using the installer, but it's using our portable zips, so it would need to "manually" add the register keys.

I thought about that so after installing with Chocolatey, I also downloaded the installer and installed it through it. Still no context menu.

@Guldoman
Copy link
Member

Oh yeah, it's because this isn't in any release yet - coming soon:tm:.

@Velosofy
Copy link
Contributor Author

Velosofy commented Aug 30, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to [ Open with lite-xl]
6 participants