Skip to content

Conversation

Jan200101
Copy link
Contributor

These are only needed for building the actual project and not for managing resources or setting various flags. Gets rid of the double source-only check and moves it closer to the consumer

These are only needed for building the actual project and not for managing resources or setting various flags.
Gets rid of the double `source-only` check and moves it closer to the consumer
@Jan200101 Jan200101 changed the title move dependency resolving into source file move dependency resolving into src meson Nov 10, 2024
@Jan200101 Jan200101 marked this pull request as ready for review November 10, 2024 14:23
Copy link
Member

@takase1121 takase1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings about this change, but I think it can make finding where the deps were declared more confusing. At the same time, having lite_link_args appearing out of thin air in src/meson.build is also weird. I guess it balances out.

Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions about this either.
How do other projects organize their meson files?

@Jan200101
Copy link
Contributor Author

qemu does it anywhere it wants to
plymouth only has it in the main meson.build but also makes sure anything consumed by a subdirectory meson.build is prepared ahead of time

there is also an alternative to what was proposed here:
moving all the heavy logic (mainly dirmonitor code) out of src/meson.build into meson.build

@adamharrison adamharrison merged commit 64420f4 into lite-xl:master Mar 15, 2025
11 checks passed
@Jan200101 Jan200101 deleted the PR/meson-reorder branch March 15, 2025 14:55
@adamharrison
Copy link
Member

Merged as per PR committee meeting 11.

takase1121 added a commit that referenced this pull request Apr 18, 2025
These are only needed for building the actual project and not for managing resources or setting various flags.
Gets rid of the double `source-only` check and moves it closer to the consumer

(cherry picked from commit 64420f4)
@takase1121 takase1121 moved this from PR to Cherry Picked in Bugfix Release Tracker Apr 18, 2025
takase1121 added a commit that referenced this pull request May 18, 2025
These are only needed for building the actual project and not for managing resources or setting various flags.
Gets rid of the double `source-only` check and moves it closer to the consumer

(cherry picked from commit 64420f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Cherry Picked
Development

Successfully merging this pull request may close these issues.

4 participants