Add filterable flag to ChangeLogParameter class (DAT-18811) #6407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spect flag when filtering changelog parameters. Global parameters such as environment variables do not get filtered, as there is no way to configure a label or context for these types of parameters.
liquibase-standard/src/main/java/liquibase/changelog/ChangeLogParameters.java
Fixed
Show fixed
Hide fixed
…st. They won't in normal cli usage, but if you're using our java apis you may get into this situation.
StevenMassaro
requested changes
Oct 8, 2024
liquibase-standard/src/test/groovy/liquibase/changelog/ChangeLogParametersTest.groovy
Show resolved
Hide resolved
liquibase-standard/src/main/java/liquibase/changelog/ChangeLogParameters.java
Show resolved
Hide resolved
filipelautert
approved these changes
Oct 8, 2024
StevenMassaro
approved these changes
Oct 8, 2024
…arameters` field which isn't filterable. This leaves global and local parameters untouched, and should enabled consistent usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Add new
systemParametersfield toChangeLogParameters. Respect newfilterableflag when filtering changelog parameters. System parameters such as environment variables do not get filtered as there is no way to configure a label or context for these types of parameters. This enables users to use label filters such as@some-filterand still have values replaced from global changelog parameters like environment variables.Things to be aware of
This pr treats every "system" parameter like environment variables as "not filterable". This is respected ONLY when these "system" parameters are set up without any filterable attributes (dbms, label, context).
Things to worry about
Additional Context