Implement logic to selectively include/exclude columns in generate-changelog "data" export (Issue #3371, #6310) #6371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
96d6571 to
8101f46
Compare
cdd8df7 to
8101f46
Compare
…angelog "data" export Both variants are supported: either includeObjects or excludeObjects. The columns are taken from "column:PATTERN" or, if both "table:" and "column:" are missing, then the entire includeObjects / excludeObjects is used to match the columns to export. If neither includeObjects nor excludeObjects are provided, all columns are considered, which is the default case. This corresponds to todays situation. This PR addresses issues liquibase#3310 and liquibase#6310 - ey, exaclt 3000 issues apart.
…ecutionException. Added logib to support case-sensitive matching.
Added CLI handling of --preserveNullValues.
… class in the end registers a MissingDataExternalFileChangeGenerator and do not unregister it.
…jects, accept the column.
…jects, accept all columns.
…rences to preserveNullValues.
…rences to preserveNullValues.
…rences to preserveNullValues.
…rences to preserveNullValues.
…rences to preserveNullValues.
…rences to preserveNullValues.
…rences to preserveNullValues.
…ntext as this class in the end registers a MissingDataExternalFileChangeGenerator and do not unregister it.
4d85e4f to
70464cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both variants are supported: either includeObjects or excludeObjects.
The columns are taken from "column:PATTERN" or, if both "table:" and "column:" are missing, then the entire includeObjects / excludeObjects is used to match the columns to export.
If neither includeObjects nor excludeObjects are provided, all columns are considered, which is the default case. This corresponds to todays situation.
This PR addresses issue #3371 - ey, exactly 3'000 issues apart - and issue #6310.
Impact
Description
This PR enhaces the generate-changelog for "data" export.
The current behaviour is to include all columns for this scenario.
This scenario is still support, so long no speficic "column:PATTERN" is provided in
--include-objectsor--exclude-objects.However, sometimes an export must be provided that skip some columns.
In that case, you may want to express it via "column:PATTERN" in either the
--include-objectsor--excludeObjects.This PR supports both cases, see the extra test case.
Things to be aware of
This PR was tested against H2, PostgreSQL and Oracle.