-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: EndDelimiter not working as expected since 4.29 #6157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d0237d
to
52fd86c
Compare
10ce265
to
fd778f6
Compare
83d51cc
to
04021a1
Compare
liquibase-integration-tests/src/test/java/liquibase/dbtest/oracle/OracleIntegrationTest.java
Outdated
Show resolved
Hide resolved
@filipelautert the default behaviour is back to "division", which I understand is what we wanted. I'm using the CLI and a basic XML changelog. Running
Note that the exception is for internalRollbackOnError. |
testing blocked by https://datical.atlassian.net/browse/DAT-18440 |
Blocked by https://github.com/liquibase/liquibase-pro/pull/1909 . CC @tati-qalified |
@tati-qalified @filipelautert this should be unblocked now |
@rberezen @filipelautert using This changeset generates the same code, no matter if strict is true or false:
Generates:
I think we're good to go with this |
@adrian-velonis1 @AMBERMW13
to
|
@rberezen yes, this seems a good description. |
[DOC TICKET] https://datical.atlassian.net/browse/PD-5023 |
Description
Consider that you have sql endDelimiter = "/" , and the following SQL:
How Liquibase should handle it? Should we split or divide? It can be understood as:
or
Historically, we had:
Versions v4.9.0 to v4.14.x (only 5 months) were
strict
while all other versions aredivision
. And with 4.29.0 we restoredstrict
because of issue #5359 (this is a case where an upgrade is being done from Liquibase 4.9.1).As we have 2 different behaviors we decided to support both by using the
strict
flag. So:--scrict
parameter ( https://docs.liquibase.com/parameters/strict.html ) .This is being documented so we don't change it again.
Fixes #6150