Skip to content

Conversation

MalloD12
Copy link
Collaborator

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fixes #5944

When LoadDataChange file contains some spaces in the headers that's causing liquibase to fail. With this PR we are adding a new configuration flag to control whether we want to trim these column names or we want to leave them as they are present in the file.

Things to be aware of

Things to worry about

Additional Context

@MalloD12 MalloD12 self-assigned this Jun 17, 2024
@MalloD12 MalloD12 requested a review from filipelautert as a code owner June 17, 2024 16:32
@MalloD12 MalloD12 changed the base branch from master to DAT-15923 June 17, 2024 16:32
@MalloD12 MalloD12 changed the base branch from DAT-15923 to master June 17, 2024 16:33
Copy link
Contributor

@StevenMassaro StevenMassaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@filipelautert filipelautert requested a review from suryaaki2 June 18, 2024 12:15
@MalloD12 MalloD12 merged commit c3e808d into master Jun 19, 2024
@MalloD12 MalloD12 deleted the fix-issue-5944 branch June 19, 2024 22:51
Copy link
Contributor

Label error: This PR is being prevented from merging because you have not added one of the labels: APIBreakingChanges, breakingChanges, newContributors, notableChanges, sdou, skipReleaseNotes, TypeBug, TypeEnhancement, TypeTest. You'll need to add it before this PR can be merged.

@adrian-velonis1
Copy link
Contributor

[DOC] https://datical.atlassian.net/browse/PD-4957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Backwards compatible was broken from version 4.3.5 to 4.4.0 and above
6 participants