Skip to content

Conversation

StevenMassaro
Copy link
Contributor

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

private Charset detectedCharset;

public BomAwareInputStream(InputStream in) throws IOException {
super(in, false, ByteOrderMark.UTF_8, ByteOrderMark.UTF_16BE, ByteOrderMark.UTF_32LE, ByteOrderMark.UTF_16LE, ByteOrderMark.UTF_32BE);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [BOMInputStream.BOMInputStream](1) should be avoided because it has been deprecated.
} catch (FileNotFoundException e) {
return null;
}
return FileUtils.readFileToString(file);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [FileUtils.readFileToString](1) should be avoided because it has been deprecated.
@StevenMassaro StevenMassaro marked this pull request as ready for review May 20, 2024 17:48
@filipelautert
Copy link
Collaborator

@StevenMassaro whoops, approved but build is broken ...

@StevenMassaro StevenMassaro merged commit b970995 into master May 28, 2024
@StevenMassaro StevenMassaro deleted the DAT-17634 branch May 28, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants