chore: invoke deprecated methods in default supports method for backwards compatibility #5897
Conversation
… extensions backwards compatibility
| default boolean supports(Class<? extends DatabaseObject> object) { | ||
| if (Sequence.class.isAssignableFrom(object)) { | ||
| return supportsSequences(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| if (Sequence.class.isAssignableFrom(object)) { | ||
| return supportsSequences(); | ||
| } else if (Schema.class.isAssignableFrom(object)) { | ||
| return supportsSchemas(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| } else if (Schema.class.isAssignableFrom(object)) { | ||
| return supportsSchemas(); | ||
| } else if (Catalog.class.isAssignableFrom(object)) { | ||
| return supportsCatalogs(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
@StevenMassaro the new support I'm adding this info to the PR description, thanks! |
TLDR:
Invoke deprecated methods in default supports method to ensure that extensions are not broken, but one day when those are removed it will return only true
Description
The new support
methodwas introduced in PR #5619 so specially NoSQL databases can check for other supports asCollectionswithout changing Database class and adding asupportsCollections()method.In core all the locations were
supportsSequences()existed were changed to supports(Sequence) , and all *Database classes had this new method implemented. But extensions don't have it, so they could return the wrong value. For instance, BigQuery doesn't support sequences but would start to return true to core.With this fix we continue to return what is expected.
Impact