GH issue #5872 improve regex for endDelimiter and rollbackEndDelimiter #5875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve regex for endDelimiter and rollbackEndDelimiter
filipelautert
approved these changes
May 3, 2024
|
@jasonlyle88 once your setup is fixed could you confirm that this one fixes your issue? |
|
@filipelautert Yup, that fix does it! Only question I have is if we want to add the word boundary check to the rest of the attribute REGEX variables? I think there are 22 more of them (i.e. Thoughts? |
|
That would be good defensive programming. It may be worth a tech debt ticket. |
rberezen
approved these changes
May 29, 2024
|
@filipelautert @wwillard7800 we need to merge fix for the pro-test with this pr |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Things to be aware of
Things to worry about
Additional Context