Skip to content

Conversation

abrackx
Copy link
Contributor

@abrackx abrackx commented Apr 15, 2024

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Sets up methods to handle the initial update, the rollback and the final update in the chain for update-testing-rollback operations. Enables extensions to hook in to lifecycle of update-testing-rollback without rewriting the whole class.

Things to be aware of

I'm happy to discuss naming conventions of these methods, I'm not a huge fan as is but can't come up with anything else.

…dStep to handle the initial update, rollback and final update.
*/
@Beta
protected void initialUpdate(Liquibase liquibase, String tag, Contexts contexts, LabelExpression labelExpression) throws Exception {
liquibase.update(tag, contexts, labelExpression);

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Liquibase.update](1) should be avoided because it has been deprecated.
@abrackx abrackx marked this pull request as ready for review April 15, 2024 13:22
@abrackx abrackx requested a review from filipelautert as a code owner April 15, 2024 13:22
@abrackx abrackx requested a deployment to internal April 16, 2024 17:54 — with GitHub Actions Abandoned
@abrackx abrackx merged commit 0e89bda into master Apr 19, 2024
@abrackx abrackx deleted the DAT-15641 branch April 19, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants