Fix (MSSQL): default end delimiter applied when there is an endDelimiter applied for a given chanset #5781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot been specified. - Test added.
filipelautert
requested changes
Apr 18, 2024
| @@ -114,7 +115,12 @@ public MSSQLDatabase() { | |||
|
|
|||
| @Override | |||
| public void executeStatements(Change change, DatabaseChangeLog changeLog, List<SqlVisitor> sqlVisitors) throws LiquibaseException { | |||
| super.executeStatements(change, changeLog, addSqlVisitors(sqlVisitors)); | |||
| if (change instanceof AbstractSQLChange && StringUtil.trimToNull(((AbstractSQLChange) change).getEndDelimiter()) != null) { | |||
| super.executeStatements(change, changeLog, sqlVisitors); | |||
There was a problem hiding this comment.
In this case a sqlvisitor for the provided end delimiter is already defined?
filipelautert
approved these changes
Apr 18, 2024
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
rberezen
approved these changes
Apr 24, 2024
… not AbstractSqlChange.
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
FOSSA Snippets Detection 🤖
|
FOSSA Test 🧪
|
|
@filipelautert @wwillard7800: I updated the logic added in this PR to avoid not appending the What this will do is, if endDelimiter is set, but it's a @rberezen: I think this should fix the current issue, but anyway this would be pending on whether this is an appropriate fix or not. Thanks, |
|
@rberezen could you test it again? thanks! |
filipelautert
approved these changes
Apr 29, 2024
rberezen
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Looks good to me, tests passed.
cc @filipelautert @MalloD12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
When
endDelimiteris specified in a changeset no default endDelimiter should be added to the SQL visitors to be applied.Fixes #5603
Things to be aware of
AppendSqlIfNotPresentVisitorwill be only applied when there is no endDelimiter set for a changeset.Things to worry about
Additional Context