remove ValueHandlerUtil and improve CLI argument parsing (DAT-15398) #5729

StevenMassaro · 2024-03-25T15:50:50Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Consolidate helper methods around value handling of arguments into one location (ObjectUtil). Also, make boolean parsing strict. Before, any unrecognized entry, foo for example, would be treated as false. Now, any unrecognized entry is treated as an invalid and an error is thrown.

Things to be aware of

Things to worry about

It is difficult to know for sure that this change will not break an edge case that someone relies on.

Additional Context

# Conflicts: # liquibase-standard/src/main/java/liquibase/util/ObjectUtil.java # liquibase-standard/src/main/java/liquibase/util/ValueHandlerUtil.java

…andler stricter

jasonlyle88 · 2024-05-03T14:04:02Z

Hey @StevenMassaro ,

I used to be able to run tests via my IDE as described in the official guide here. However, this no longer works.

After spending some time, I was able to narrow it down to this PR that caused the issue. Checking out the commit right before this one (2350d09fc51cf51eea2f95e6f169c6f587723132) works with the IDE testing, but checking out the commit from this PR (89995c7a4411e3b9a68b5d13fb6954cda4f2f07e) causes the IDE testing to fail.

Below is the error message produced when I try to execute a test through the IDE:

/Library/Java/JavaVirtualMachines/temurin-21.jdk/Contents/Home/bin/java -javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=57932:/Applications/IntelliJ IDEA.app/Contents/bin -Dfile.encoding=UTF-8 -Dsun.stdout.encoding=UTF-8 -Dsun.stderr.encoding=UTF-8 -classpath /Users/jlyle/Personal/projects/liquibase/liquibase/liquibase-cli/target/classes:/Users/jlyle/Personal/projects/liquibase/liquibase/liquibase-standard/target/classes:/Users/jlyle/.m2/repository/com/opencsv/opencsv/5.9/opencsv-5.9.jar:/Users/jlyle/.m2/repository/org/apache/commons/commons-lang3/3.13.0/commons-lang3-3.13.0.jar:/Users/jlyle/.m2/repository/org/apache/commons/commons-text/1.11.0/commons-text-1.11.0.jar:/Users/jlyle/.m2/repository/org/apache/commons/commons-collections4/4.4/commons-collections4-4.4.jar:/Users/jlyle/.m2/repository/org/yaml/snakeyaml/2.2/snakeyaml-2.2.jar:/Users/jlyle/.m2/repository/javax/xml/bind/jaxb-api/2.3.1/jaxb-api-2.3.1.jar:/Users/jlyle/.m2/repository/info/picocli/picocli/4.7.5/picocli-4.7.5.jar liquibase.integration.commandline.LiquibaseLauncher update
May 03, 2024 9:52:57 AM liquibase.servicelocator
INFO: Cannot load service
java.util.ServiceConfigurationError: liquibase.configuration.AutoloadedConfigurations: Provider com.datical.liquibase.ext.config.ReportConfiguration could not be instantiated
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
	at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
	at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
	at liquibase.servicelocator.StandardServiceLocator.findInstances(StandardServiceLocator.java:24)
	at liquibase.configuration.LiquibaseConfiguration.init(LiquibaseConfiguration.java:61)
	at liquibase.Scope.getCurrentScope(Scope.java:102)
	at liquibase.command.CommandArgumentDefinition$Building.build(CommandArgumentDefinition.java:299)
	at liquibase.command.core.CalculateChecksumCommandStep.<clinit>(CalculateChecksumCommandStep.java:52)
	at liquibase.integration.commandline.LiquibaseCommandLine.<init>(LiquibaseCommandLine.java:117)
	at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:102)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at liquibase.integration.commandline.LiquibaseLauncher.main(LiquibaseLauncher.java:116)
Caused by: java.lang.NoSuchMethodError: 'java.lang.Boolean liquibase.util.ValueHandlerUtil.booleanValueHandler(java.lang.Object)'
	at com.datical.liquibase.ext.config.ReportConfiguration.<clinit>(ReportConfiguration.java:28)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized(MethodHandleAccessorFactory.java:300)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor(MethodHandleAccessorFactory.java:103)
	at java.base/jdk.internal.reflect.ReflectionFactory.newConstructorAccessor(ReflectionFactory.java:200)
	at java.base/java.lang.reflect.Constructor.acquireConstructorAccessor(Constructor.java:549)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:789)
	... 12 more

May 03, 2024 9:52:57 AM liquibase.servicelocator
INFO: Cannot load service
java.util.ServiceConfigurationError: liquibase.configuration.AutoloadedConfigurations: Provider com.datical.liquibase.ext.config.DatabaseChangelogHistoryConfiguration could not be instantiated
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
	at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
	at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
	at liquibase.servicelocator.StandardServiceLocator.findInstances(StandardServiceLocator.java:24)
	at liquibase.configuration.LiquibaseConfiguration.init(LiquibaseConfiguration.java:61)
	at liquibase.Scope.getCurrentScope(Scope.java:102)
	at liquibase.command.CommandArgumentDefinition$Building.build(CommandArgumentDefinition.java:299)
	at liquibase.command.core.CalculateChecksumCommandStep.<clinit>(CalculateChecksumCommandStep.java:52)
	at liquibase.integration.commandline.LiquibaseCommandLine.<init>(LiquibaseCommandLine.java:117)
	at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:102)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at liquibase.integration.commandline.LiquibaseLauncher.main(LiquibaseLauncher.java:116)
Caused by: java.lang.NoSuchMethodError: 'java.lang.Boolean liquibase.util.ValueHandlerUtil.booleanValueHandler(java.lang.Object)'
	at com.datical.liquibase.ext.config.DatabaseChangelogHistoryConfiguration.<clinit>(DatabaseChangelogHistoryConfiguration.java:56)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized(MethodHandleAccessorFactory.java:300)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor(MethodHandleAccessorFactory.java:103)
	at java.base/jdk.internal.reflect.ReflectionFactory.newConstructorAccessor(ReflectionFactory.java:200)
	at java.base/java.lang.reflect.Constructor.acquireConstructorAccessor(Constructor.java:549)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:789)
	... 12 more

May 03, 2024 9:52:58 AM liquibase.servicelocator
INFO: Cannot load service
java.util.ServiceConfigurationError: liquibase.command.CommandStep: Provider com.datical.liquibase.ext.command.helpers.ChecksAutoEnableNewChecksArgument could not be instantiated
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
	at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
	at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
	at liquibase.servicelocator.StandardServiceLocator.findInstances(StandardServiceLocator.java:24)
	at liquibase.command.CommandFactory.findAllInstances(CommandFactory.java:244)
	at liquibase.command.CommandFactory.getCommands(CommandFactory.java:163)
	at liquibase.integration.commandline.LiquibaseCommandLine.getCommands(LiquibaseCommandLine.java:1115)
	at liquibase.integration.commandline.LiquibaseCommandLine.buildPicoCommandLine(LiquibaseCommandLine.java:218)
	at liquibase.integration.commandline.LiquibaseCommandLine.<init>(LiquibaseCommandLine.java:194)
	at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:102)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at liquibase.integration.commandline.LiquibaseLauncher.main(LiquibaseLauncher.java:116)
Caused by: java.lang.NoSuchMethodError: 'java.lang.Boolean liquibase.util.ValueHandlerUtil.booleanValueHandler(java.lang.Object)'
	at com.datical.liquibase.ext.command.helpers.ChecksAutoEnableNewChecksArgument.<clinit>(ChecksAutoEnableNewChecksArgument.java:23)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized(MethodHandleAccessorFactory.java:300)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor(MethodHandleAccessorFactory.java:103)
	at java.base/jdk.internal.reflect.ReflectionFactory.newConstructorAccessor(ReflectionFactory.java:200)
	at java.base/java.lang.reflect.Constructor.acquireConstructorAccessor(Constructor.java:549)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:789)
	... 12 more

May 03, 2024 9:52:58 AM liquibase.servicelocator
INFO: Cannot load service
java.util.ServiceConfigurationError: liquibase.command.CommandStep: Provider com.datical.liquibase.ext.command.checks.ChecksRunCommandStep could not be instantiated
	at java.base/java.util.ServiceLoader.fail(ServiceLoader.java:586)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:813)
	at java.base/java.util.ServiceLoader$ProviderImpl.get(ServiceLoader.java:729)
	at java.base/java.util.ServiceLoader$3.next(ServiceLoader.java:1403)
	at liquibase.servicelocator.StandardServiceLocator.findInstances(StandardServiceLocator.java:24)
	at liquibase.command.CommandFactory.findAllInstances(CommandFactory.java:244)
	at liquibase.command.CommandFactory.getCommands(CommandFactory.java:163)
	at liquibase.integration.commandline.LiquibaseCommandLine.getCommands(LiquibaseCommandLine.java:1115)
	at liquibase.integration.commandline.LiquibaseCommandLine.buildPicoCommandLine(LiquibaseCommandLine.java:218)
	at liquibase.integration.commandline.LiquibaseCommandLine.<init>(LiquibaseCommandLine.java:194)
	at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:102)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at liquibase.integration.commandline.LiquibaseLauncher.main(LiquibaseLauncher.java:116)
Caused by: java.lang.NoSuchMethodError: 'java.lang.Boolean liquibase.util.ValueHandlerUtil.booleanValueHandler(java.lang.Object)'
	at com.datical.liquibase.ext.command.checks.ChecksRunCommandStep.<clinit>(ChecksRunCommandStep.java:211)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized0(Native Method)
	at java.base/jdk.internal.misc.Unsafe.ensureClassInitialized(Unsafe.java:1160)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.ensureClassInitialized(MethodHandleAccessorFactory.java:300)
	at java.base/jdk.internal.reflect.MethodHandleAccessorFactory.newConstructorAccessor(MethodHandleAccessorFactory.java:103)
	at java.base/jdk.internal.reflect.ReflectionFactory.newConstructorAccessor(ReflectionFactory.java:200)
	at java.base/java.lang.reflect.Constructor.acquireConstructorAccessor(Constructor.java:549)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at java.base/java.util.ServiceLoader$ProviderImpl.newInstance(ServiceLoader.java:789)
	... 12 more

Exception in thread "main" java.lang.reflect.InvocationTargetException
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:118)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at liquibase.integration.commandline.LiquibaseLauncher.main(LiquibaseLauncher.java:116)
Caused by: java.lang.IllegalStateException: Unable to find CommandStep provider for class com.datical.liquibase.ext.command.helpers.ChecksAutoEnableNewChecksArgument
	at liquibase.command.CommandFactory.lambda$whoProvidesClass$4(CommandFactory.java:121)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at liquibase.command.CommandFactory.whoProvidesClass(CommandFactory.java:121)
	at liquibase.command.CommandFactory.findDependenciesForCommand(CommandFactory.java:104)
	at liquibase.command.CommandFactory.computePipelineForCommandDefinition(CommandFactory.java:77)
	at liquibase.command.CommandFactory.getCommandDefinition(CommandFactory.java:50)
	at liquibase.command.CommandFactory.getCommands(CommandFactory.java:175)
	at liquibase.integration.commandline.LiquibaseCommandLine.getCommands(LiquibaseCommandLine.java:1115)
	at liquibase.integration.commandline.LiquibaseCommandLine.buildPicoCommandLine(LiquibaseCommandLine.java:218)
	at liquibase.integration.commandline.LiquibaseCommandLine.<init>(LiquibaseCommandLine.java:194)
	at liquibase.integration.commandline.LiquibaseCommandLine.main(LiquibaseCommandLine.java:102)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	... 2 more

Process finished with exit code 1

Any thoughts on what is going on here?

jasonlyle88 · 2024-05-03T17:13:28Z

Hey @StevenMassaro , @filipelautert helped me resolve this issue on another thread. I had my LIQUIBASE_HOME set to a Liquibase 4.27.0 release because of the instructions. But that cased a mis-match in code that was updated vs code that was trying to run. So my previous message can safely be ignored!

StevenMassaro added 4 commits March 25, 2024 08:20

move Level parsing into global value handler class

7a57d2b

remove getEnum

d198ffe

remove added unroll annotation

9c55fd6

Merge branch 'master' into DAT-15398

6fcec82

# Conflicts: # liquibase-standard/src/main/java/liquibase/util/ObjectUtil.java # liquibase-standard/src/main/java/liquibase/util/ValueHandlerUtil.java

StevenMassaro added the notableChanges label Mar 25, 2024

StevenMassaro temporarily deployed to internal March 25, 2024 15:50 — with GitHub Actions Inactive

StevenMassaro temporarily deployed to internal March 25, 2024 17:02 — with GitHub Actions Inactive

remove custom boolean value handlers and make default boolean value h…

cd928aa

…andler stricter

StevenMassaro added breakingChanges and removed notableChanges labels Mar 26, 2024

StevenMassaro temporarily deployed to internal March 26, 2024 18:10 — with GitHub Actions Inactive

StevenMassaro temporarily deployed to internal March 26, 2024 20:04 — with GitHub Actions Inactive

StevenMassaro marked this pull request as ready for review March 27, 2024 12:24

StevenMassaro requested a review from filipelautert as a code owner March 27, 2024 12:24

StevenMassaro requested review from wwillard7800, abrackx and suryaaki2 March 27, 2024 12:25

StevenMassaro temporarily deployed to internal March 27, 2024 12:43 — with GitHub Actions Inactive

wwillard7800 approved these changes Mar 27, 2024

View reviewed changes

StevenMassaro temporarily deployed to internal March 27, 2024 13:38 — with GitHub Actions Inactive

suryaaki2 approved these changes Mar 28, 2024

View reviewed changes

StevenMassaro merged commit 89995c7 into master Apr 1, 2024

StevenMassaro deleted the DAT-15398 branch April 1, 2024 12:12

jasonlyle88 mentioned this pull request May 3, 2024

Changeset execution information properties #5598

Merged

3 tasks

jandroav added the notableChanges label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove ValueHandlerUtil and improve CLI argument parsing (DAT-15398) #5729

remove ValueHandlerUtil and improve CLI argument parsing (DAT-15398) #5729

Uh oh!

StevenMassaro commented Mar 25, 2024 •

edited by filipelautert

Loading

Uh oh!

jasonlyle88 commented May 3, 2024 •

edited

Loading

Uh oh!

jasonlyle88 commented May 3, 2024

Uh oh!

Uh oh!

remove ValueHandlerUtil and improve CLI argument parsing (DAT-15398) #5729

remove ValueHandlerUtil and improve CLI argument parsing (DAT-15398) #5729

Uh oh!

Conversation

StevenMassaro commented Mar 25, 2024 • edited by filipelautert Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Impact

Description

Things to be aware of

Things to worry about

Additional Context

Uh oh!

jasonlyle88 commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jasonlyle88 commented May 3, 2024

Uh oh!

Uh oh!

StevenMassaro commented Mar 25, 2024 •

edited by filipelautert

Loading

jasonlyle88 commented May 3, 2024 •

edited

Loading