Format spring package. #5597
Merged
Format spring package. #5597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquibase-standard/src/main/java/liquibase/integration/spring/SpringLiquibase.java
Fixed
Show fixed
Hide fixed
…sashour-format
… says is deprecated in javadoc.
MalloD12
approved these changes
Feb 29, 2024
filipelautert
requested changes
Mar 4, 2024
liquibase-standard/src/main/java/liquibase/integration/spring/MultiTenantSpringLiquibase.java
Outdated
Show resolved
Hide resolved
filipelautert
approved these changes
Mar 5, 2024
| @@ -60,72 +62,88 @@ | |||
| protected final Logger log = Scope.getCurrentScope().getLog(SpringLiquibase.class); | |||
| protected String beanName; | |||
|
|
|||
| protected ResourceLoader resourceLoader; | |||
| @Getter | |||
| @Setter | |||
Check notice
Code scanning / CodeQL
Missing Override annotation
filipelautert
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code sometimes uses 2-space indentation and 4-space one.
I think it makes sense to format the spring package (for now) for 4-space indentation, as a preparation to work on a PR for that package.
Please let me know if 2-space one is preferred.