database changelog history record-keeping (DAT-16178) #5147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from factory (DAT-15985) (#5123)
| @@ -23,7 +25,7 @@ | |||
| return results; | |||
| } | |||
|
|
|||
| public int getExitCode() { | |||
| public Integer getExitCode() { | |||
Check notice
Code scanning / CodeQL
Missing Override annotation
| private static final long serialVersionUID = 1570124571347160550L; | ||
| private Integer exitCode = null; |
Check notice
Code scanning / CodeQL
Missing Override annotation
| return null; | ||
| } | ||
|
|
||
| public static class LibraryInfo implements Comparable<LibraryInfo> { |
Check warning
Code scanning / CodeQL
Inconsistent compareTo
…ing history table (DAT-15973) (#5203)
| @@ -7,4 +7,7 @@ | |||
| public interface ChangeLogSyncListener { | |||
| void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database); | |||
|
|
|||
| default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -7,4 +7,7 @@ | |||
| public interface ChangeLogSyncListener { | |||
| void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database); | |||
|
|
|||
| default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -7,4 +7,7 @@ | |||
| public interface ChangeLogSyncListener { | |||
| void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database); | |||
|
|
|||
| default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -7,4 +7,7 @@ | |||
| public interface ChangeLogSyncListener { | |||
| void markedRan(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database); | |||
|
|
|||
| default void markedRanFailed(ChangeSet changeSet, DatabaseChangeLog databaseChangeLog, Database database, Exception e) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -83,6 +89,11 @@ | |||
| resultsBuilder.addResult("statusCode", 0); | |||
| } | |||
|
|
|||
| public SnapshotControl getSnapshotControl(CommandScope commandScope, Database database) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -83,6 +89,11 @@ | |||
| resultsBuilder.addResult("statusCode", 0); | |||
| } | |||
|
|
|||
| public SnapshotControl getSnapshotControl(CommandScope commandScope, Database database) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
…5375) add dbcl-history configuration options to maven plugin
# Conflicts: # liquibase-standard/src/main/java/liquibase/command/CommandScope.java # liquibase-standard/src/main/java/liquibase/database/Database.java
# Conflicts: # liquibase-cli/src/main/java/liquibase/integration/commandline/LiquibaseCommandLine.java
| * @parameter property="liquibase.verbose" | ||
| */ | ||
| @PropertyElement | ||
| protected Boolean verbose; |
Check warning
Code scanning / CodeQL
Field masks field in super class
add maven arguments to scope
…en (DAT-16881) (#5609) fix dbclHistoryEnabled property from liquibase.properties file in maven
record executed SQL in ChangelogJdbcMdcListener
| default void addCompleteSqlToScope(String completeSql) { | ||
| AtomicReference<String> sqlsReference = Scope.getCurrentScope().get(COMPLETE_SQL_SCOPE_KEY, AtomicReference.class); | ||
| if (sqlsReference != null) { | ||
| sqlsReference.set(completeSql.toString()); |
Check notice
Code scanning / CodeQL
Useless toString on String
…0) (#5651) * add captureExtensions and captureSql params to maven plugin * update javadoc * additional javadoc fixes
filipelautert
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
The current DBCL tracks changes currently applied to a db, but when changes are rolledback, these changeset records dissappear. This new PRO table, DATABASECHANGELOGHISTORY, will track all changes made and rolled back and dropped. The overall goal of this table is track the history of database changing liquibase operations, including rollbacks, dropall, repeated updates of the same changeset, etc.
Things to be aware of
Things to worry about
Additional Context