Skip to content

Don't eagerly remove golang gc references in Destroy #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

Don't eagerly remove golang gc references in Destroy #174

merged 2 commits into from
Mar 25, 2025

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Feb 24, 2025 •
edited
Loading

  1. it's not necessary with golang gc.
  2. user may want to keep reference it indirectly

ref: #172

@yihuang
don't eagerly remove golang gc references in Destroy
b46a57f 
1. it's not necessary
2. user may want to keep reference it indirectly

ref: linxGnu#172
@yihuang yihuang mentioned this pull request Feb 24, 2025
Merged
@linxGnu linxGnu changed the title don't eagerly remove golang gc references in Destroy Don't eagerly remove golang gc references in Destroy Mar 3, 2025
linxGnu
linxGnu approved these changes Mar 25, 2025
View reviewed changes
Copy link
Owner

@linxGnu linxGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linxGnu linxGnu merged commit 9cdf8b3 into linxGnu:master Mar 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linxGnu linxGnu linxGnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yihuang @linxGnu