Bump the node dependencies #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: grampelberg <thomas@saunter.org>
ffd2978 to
40b1365
Compare
adleong
reviewed
May 5, 2020
There was a problem hiding this comment.
Thanks, @grampelberg! Are the whitespace changes here functional in some way?
|
@adleong yeah, it gets lint to pass. No idea how it was passing before (though may be related to the eslint version bump). |
|
circleci seems stuck and/or confused on this one. @grampelberg maybe try pushing an empty commit to see if that unsticks it? |
Signed-off-by: grampelberg <thomas@saunter.org>
2bf7767 to
e8cd745
Compare
|
@adleong I have no idea what is up with Circle status, but can you rerun the job? Pretty sure that error is transient. |
cpretzer
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.