Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Mar 18, 2020

No description provided.

@ghost ghost requested review from adleong, olix0r and zaharidichev as code owners March 18, 2020 14:32
Signed-off-by: James Lawrie <james.lawrie@nytimes.com>
@ghost
Copy link
Author

ghost commented Mar 18, 2020

Fixes #2378

@cpretzer
Copy link
Contributor

Thank you @jlawrienyt, this is really helpful.

Will take a look and get this PR merged after all the checks pass.

Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @jlawrienyt! This looks correct to me. ⭐

Copy link
Member

@zaharidichev zaharidichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Bonus points for the test!

@adleong adleong merged commit 3e64562 into linkerd:master Mar 24, 2020
@ghost ghost deleted the grpc-trailers-only-fix branch March 25, 2020 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants