[#2352] Add configuration server.serverSession to allow expiring server conne… #2353
Conversation
…ctions Signed-off-by: Robert Panzer <robert.panzer.pb@googlemail.com>
|
The reasoning behind this is solid. However, I do wonder whether this could be achieved with setting socket options on the server. You can read a bit more about it right here. Let me know if that helps? |
|
The only option that I see that could help in such a scenario would be enabling SO_KEEPALIVE. |
There was a problem hiding this comment.
This looks great, thanks @robertpanzer!
I tested this manually by running a Linkerd locally with the server session options and initiating connections with nc and watching how long they took to idle out or hit their maximum lifetime. Everything worked as expected.
|
|
||
| serverIdleTimeMsBaseTest(config){ (router:Router.Initialized, stats:InMemoryStatsReceiver) => | ||
| // Assert | ||
| def connectsCount = () => stats.counters(Seq("rt", "http", "server", "127.0.0.1/0", "connects")) |
There was a problem hiding this comment.
I don't think this needs to be a closure, I think it can simply be a def, similarly to how metrics are checked elsewhere in this file:
def connectsCount = stats.counters(Seq("rt", "http", "server", "127.0.0.1/0", "connects"))
There was a problem hiding this comment.
Thanks @adleong!
I updated the PR.
CircleCI seems to have failed on downloading a zookeeper dependency, could you please trigger a rebuild?
There was a problem hiding this comment.
Nice work!!! This can be merged once you fix the DCO problem that you can read more about here
…Test Signed-off-by: Robert Panzer <robert.panzer.pb@googlemail.com>
d8edcaa to
3de5f68
Compare
|
Thanks! |
|
Sorry that it's taking us so long to get this merged, @robertpanzer! The CI failure here is also happening on master. I am looking into it. |
|
Sure, thanks for letting me know! |
|
The build issue on master has been resolved and this is good to go! Thanks for your patience, @robertpanzer! |
|
\o/ Awesome! Thanks for merging! |
…ctions
This PR fixes #2352.
There might be clients opening connections to Linkerd not closing them properly.
Also sometimes network components might silently drop connections to Linkerd.
This results in connections that are never closed and after a longer time this might accumulate to so many open connections until the Linkerd process runs out of file handles.
Right now I could not find a configuration parameter to control expiring of inbound connections like it is supported for client connections.
Therefore this PR proposes to add a configuration parameter
serverSessionto a server that behaves similar to theclientSession.With the following configuration server connections will be closed after 2 seconds of idling or after a full life time of 30 seconds: