Add a new filter that logs inbound requests to Namerd #2275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
919f275 to
81b8935
Compare
adleong
reviewed
May 28, 2019
| import java.net.InetSocketAddress | ||
|
|
||
| object AccessLogger { | ||
| def mk( |
There was a problem hiding this comment.
This method which processes option properties and applies defaults feels out of place in a pure library like this. I think this logic would fit better directly in MeshIfaceInitializer.
| val filter = logFilePath match { | ||
| case Some(path) if path != "" => | ||
| val logger = LoggerFactory( | ||
| node = "access_io.l5d.mesh", |
There was a problem hiding this comment.
I don't think this logger node name is appropriate for an arbitrary access logger, but if you move this into the mesh iface initializer, I think it makes much more sense.
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
adleong
approved these changes
May 29, 2019
| var h2AccessLogRotateCount: Option[Int] = None | ||
|
|
||
| @JsonIgnore | ||
| def mkAccessLogger( |
| val append = logAppend.getOrElse(true) | ||
| val logRotate = logRotateCount.getOrElse(-1) | ||
|
|
||
| val filter = logFilePath match { |
There was a problem hiding this comment.
why save this to a val and then immediately return it?
There was a problem hiding this comment.
I think it may be left over from me debugging this piece of code. Good catch.
Signed-off-by: Dennis Adjei-Baah <dennis@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to see what requests are being made to a Namerd process, this PR adds a
SimpleFilterto the mesh interface to log every inbound request to Namerd in the Common Log Format.Running a docker compose environment with Linkerd and Namerd, resolving service names in Linkerd's dtab playground yields these log lines in Namerd.
Fixes #2255
Signed-off-by: Dennis Adjei-Baah dennis@buoyant.io