Update computeJoinedDF to take a DataFrame #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The computeJoinedDF method accepts a DataFrameReader to load the protected attribute DataFrame. However, this means that the data must necessarily be read / loaded in, and that a DataFrameReader must be used to achieve this. The API is updated now to accept a DataFrame instead. * The version is bumped to 0.2.0 due to the API change. * Fixed a unit test for computeModelMetrics that was testing computeDatasetMetrics instead. * Fixed some code style issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computeJoinedDFmethod accepts aDataFrameReaderto load the protected attributeDataFrame. However, this means that the data must necessarily be read / loaded in, and that aDataFrameReadermust be used to achieve this. The API is updated now to accept aDataFrameinstead.computeDatasetMetricsinstead.