Skip to content

initial support for ignoring access errors #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

lingrino
Copy link
Owner

This PR adds a flag --ignore-access-errors and an api option ignoreAccessErrors that can be used to return nil data instead of an error on read and list operations. Which should be useful in cases where you have partial access to a folder and want to search / list / etc... over at least the things you have access to.

This could be expanded in the future in two ways:

  • This change only covers list and read. Are there other cases where it makes sense to add?
  • This change ignores all errors but could be narrowed down to only specific access related errors.

Should fix #402 and close #1583

Copy link

cloudflare-workers-and-pages bot commented Oct 28, 2024

Deploying vaku with  Cloudflare Pages  Cloudflare Pages

Latest commit: f6fef7d
Status: ✅  Deploy successful!
Preview URL: https://c7cbb562.vaku.pages.dev
Branch Preview URL: https://ignore-access-error.vaku.pages.dev

View logs

@lingrino lingrino merged commit 2222e3c into main Oct 28, 2024
8 checks passed
@lingrino lingrino deleted the ignore-access-error branch October 28, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to pass paths on error
1 participant