-
-
Notifications
You must be signed in to change notification settings - Fork 90
allow multiple identical devices to be configured #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
allow multiple identical devices to be configured #940
Conversation
Thanks a lot for the contribution! I'm not sure prepending the When I originally designed this, I considered using Also, this change introduces a breaking change: since the |
…ion and were indistinguishable
9dfe1c7
to
a625d1c
Compare
Yeah, I was just doing some testing and noticed that and made a change (force pushed) to basically just add the
Well, what I just changed would now only break configurations IF people had multiple identical devices-- which might be unlikely? |
Thanks for your quick response. I'm still not convinced I agree that it makes sense to distinguish between devices with the same product name in the UI. However, our first step should probably be figuring out how to get a stable serial number / identifier for them. If you can shed some light on why the device isn't acquiring a serial number, we might be able to offer more targeted solutions. |
4d0f3db
to
7b6194d
Compare
and also just changed the UI's duplicate handling of |
Adding However, the logic around implementing
Ideally, we'll need a more comprehensive scheme management user interface to effectively handle these scenarios. I also noticed #906. This |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
After my last pull request was merged in for the
pointerRedirectsToScroll
feature, I realized that if you have two identical devices (such as two trackballs that are the same model from the same manufacturer), the configuration object currently is shared for BOTH devices, so impossible to make one handle mouse events, and the other redirect to scroll.The changes in this PR fix this behavior, so now if there are multiple identical devices then a number is appended to the name in the settings UI so they will show up like "CST Laser Trackball #1" and "CST Laser Trackball #2". But if there is only one device of a type, then it will not show that number.
In order to ensure a unique configuration object was created for each duplicate device, I needed to include something in the
productName
property to differentiate the devices, so I used the device'sid
property for that.Thanks.