Fix flaky tests using Awaitility.await().untilAsserted()
#6171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daeho Kwon <trewq231@naver.com>
jrhee17
approved these changes
Mar 25, 2025
|
Thanks, @kwondh5217! |
|
Thanks for merging the PR, @trustin ! I appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The test failure in #6149 occurs because the assertion was executed before the CompletableFuture was completed. This caused intermittent test failures when the test attempted to check the completion status too early.
Modifications:
Replaced direct assertions using assertThat() with await().untilAsserted() to properly wait for asynchronous operations to complete before asserting their results.
Applied the same fix to all test cases where the completion state of CompletableFuture was verified to ensure consistency and reliability.
Result:
com.linecorp.armeria.common.multipart.MultipartDecoderTest.[1] subscriberType=INFINITE#6149