Calculate midterm penalty based on slashings vector in state #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F4ever
reviewed
Feb 27, 2025
F4ever
reviewed
Feb 27, 2025
F4ever
reviewed
Feb 27, 2025
F4ever
reviewed
Feb 27, 2025
F4ever
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Change calculation of predicted midterm penalty.
Why
At the moment we are calculating predicted midterm penalty based on an effective_balance of the validator. This calculations based on a
ref_sloteffective_balance. What we want to do instead is to calculate it based onslashingsfrom the state as per spec. This will provide more accurate midterm slashing predictions.How
We are predicting the penalty in future, so we want to cut the epochs which will be replaced, by the time chain reach midterm slashing epoch. This is what
_cut_slashingsdoes