Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

Massive update using the vendor list - help wanted! #104

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Massive update using the vendor list - help wanted! #104

merged 4 commits into from
Oct 7, 2019

Conversation

lightswitch05
Copy link
Owner

@lightswitch05 lightswitch05 commented Sep 27, 2019 •
edited
Loading

Massive update using the vendor list found here #102 (comment) - so far only got to ID 1313.

This is a massive list update and it is bound to have some false positives in it. I would be very grateful to anyone willing to use this updated blocklist for the next few weeks and report back any issues. So far I've only added about a little under half of the full list - so more updates to this pull request coming over the next few days.

Link to use for testing over the next few weeks: https://raw.githubusercontent.com/lightswitch05/hosts/feature/hosts-from-vendor-list/ads-and-tracking-extended.txt

@lightswitch05 lightswitch05 added enhancement New feature or request help wanted Extra attention is needed labels Sep 27, 2019
@baujahr
Copy link

baujahr commented Sep 28, 2019 

pciins-033.inscname.net
d2v02itv0y9u9t.cloudfront.net
a054.zamnetwork.inscname.net
a-h2-instartops-002.insnw.net

Blocking of these domains breaks stylesheet on https://wowhead.com

@baujahr
Copy link

baujahr commented Sep 28, 2019 •
edited
Loading

Blocking

googleadapis.l.google.com
gstaticadssl.l.google.com

indirectly also blocks

fonts.googleapis.com
fonts.gstatic.com

@lightswitch05
Copy link
Owner Author 

googleadapis.l.google.com
gstaticadssl.l.google.com

These are blocked in the primary list already and not related to this pull request. Fonts are a fine line between functionality and tracking- I'm leaning on the side that I would rather have these ad hosts blocked. You could open another ticket for these and I could leave it open for tracking, but its not related to this pull request

@lightswitch05
Copy link
Owner Author 

pciins-033.inscname.net
d2v02itv0y9u9t.cloudfront.net
a054.zamnetwork.inscname.net
a-h2-instartops-002.insnw.net

These are also already blocked in the master branch - so also not related to this pull request and need to be tracked elsewhere

@dnmTX
Copy link

dnmTX commented Sep 30, 2019

@lightswitch05

These are blocked in the primary list already and not related to this pull request. Fonts are a fine line between functionality and tracking- I'm leaning on the side that I would rather have these ad hosts blocked.....

Apparently some DNS Resolvers are blocking not only the listed domain but it's CNAME as well.
In this case googleadapis.l.google.com is the CNAME of fonts.googleapis.com.
Refer to this issue for more info and i believe there is another one with the same complaint in StevenBlack's repo.
I'm not saying remove it,just keep in mind for the feature and for your reference. 👍

@lightswitch05
Copy link
Owner Author

My plan was to fully get through the list before merging this. But at this rate, its never going to happen. I'm going to go ahead and merge this and open up another pull request in the future when I get back to it

@lightswitch05 lightswitch05 merged commit 6b3b241 into master Oct 7, 2019
@lightswitch05 lightswitch05 mentioned this pull request Nov 1, 2019
Closed
@hectorm hectorm mentioned this pull request Feb 29, 2020
Closed
@lightswitch05 lightswitch05 deleted the feature/hosts-from-vendor-list branch May 28, 2020 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lightswitch05 @baujahr @dnmTX