multi: use lndclient MacaroonService #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbdc158 to
fbcd696
Compare
guggero
reviewed
Jan 13, 2022
b7f4372 to
8dfa0d2
Compare
ellemouton
commented
Jan 14, 2022
ellemouton
commented
Jan 14, 2022
8dfa0d2 to
0a99f9b
Compare
Since the code for creating and using a macaroon service is the same for multiple projects (pool, loop, litd etc), the code has been unified in lndclient. So this commit removes the macaroon service code and instead uses the lndclient code.
Rename createDefaultMacaroonFile to withMacaroonService since this is now a more appropriate name.
0a99f9b to
c4d43e7
Compare
positiveblue
approved these changes
Jan 18, 2022
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
…l-itests mod+itest: update to latest Pool version and add itest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the code for creating and using a macaroon service is the same for
multiple projects (pool, loop, litd etc), the code has been unified in
lndclient. So this commit removes the macaroon service code and instead
uses the lndclient code.
Depends on lightninglabs/lndclient#86