tools: update Golang to 1.18, add fuzz tests #384
Conversation
| - stylecheck | ||
| - thelper | ||
| - nosprintfhostport | ||
| - errchkjson |
There was a problem hiding this comment.
Didn't check with other linters, but errchkjson and nosprintfhostport could be removed and the linter still runs through just well. At some point we might need to go through all the linters and either code-adjust or change the comment above.
There was a problem hiding this comment.
Yes, I agree, we should probably take the time to set a fixed list of linters we want to have active and then synchronize all the linter setting files across all our projects.
ae93ad2 to
30680e7
Compare
The docker build image cache seems to cause more problems and take longer to load than it would take to build the image from scratch, so we remove it. Instead we make sure that we use the latest version of the 1.18 Golang branch.
|
I have no idea why the mock generation fails on GitHub. I cannot reproduce it locally, neither by running the command directly nor with the dockerized GitHub actions runner |
Can't reproduce either |
The docker image was sharing the cache dir with the host and that was causing some permission problems in our ci (github actions).
|
@guggero i added a commit on top of yours fixing the mock gen step. We were sharing the go cache with the host and that was causing some permission problems. |
|
@positiveblue thanks for figuring it out 🎉 |
…ency-fix monitoring: concurrency fix
Wanted to add fuzz test coverage in another PR and noticed we'd need to bump the tool chain (and with it the linter) to Go 1.18 first.