Skip to content

Usability fixes #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

Usability fixes #378

merged 2 commits into from
Jul 12, 2022

Conversation

guggero
Copy link
Contributor

@guggero guggero commented Jul 12, 2022

Pull Request Checklist

  • LndServices minimum version has been updated if new lnd apis/fields are
    used.

@guggero guggero requested a review from positiveblue July 12, 2022 19:21
@guggero guggero marked this pull request as ready for review July 12, 2022 19:27
positiveblue
positiveblue approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guggero guggero merged commit 574c179 into master Jul 12, 2022
@guggero guggero deleted the usability-fixes branch July 12, 2022 19:36
positiveblue pushed a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
@guggero
Merge pull request lightninglabs#378 from lightninglabs/fix-sidecar-p…
e55edc6 
…artial-rejects

sidecar: handle sidecar partial rejects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@positiveblue positiveblue positiveblue approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guggero @positiveblue