Skip to content

Conversation

positiveblue
Copy link
Contributor

Thaw height is now absoulte (used to be relative). We could check the
channel type (for type SCRIPT_ENFORCED_LEASE is always absolute) but
we can simply follow the "500,000" value rule.

Thaw height is now absoulte (used to be relative). We could check the
channel type (for type SCRIPT_ENFORCED_LEASE is always absolute) but
we can simply follow the "500,000" value rule.
@positiveblue positiveblue requested a review from guggero March 15, 2022 06:15
Copy link
Contributor

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice fix 🎉

@guggero guggero linked an issue Mar 15, 2022 that may be closed by this pull request
@guggero guggero merged commit 10d7972 into master Mar 15, 2022
@guggero guggero deleted the fix-346 branch March 15, 2022 09:31
positiveblue pushed a commit to positiveblue/pool that referenced this pull request Oct 11, 2022
subastadb: fix SQL error when attempting to store empty slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lease created with wrong expire height
2 participants