cmd/poold: pprof listen on localhost #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, debugging information is exposed if the port is reachable.
halseth
suggested changes
Mar 5, 2021
| @@ -77,7 +77,7 @@ func start() error { | |||
| } | |||
|
|
|||
| go func() { | |||
| listenAddr := net.JoinHostPort("", config.Profile) | |||
| listenAddr := net.JoinHostPort("127.0.0.1", config.Profile) | |||
There was a problem hiding this comment.
there are very valid use case for allowing profiling on a externally reachable port though. Could we make the config.Profile option optionally set this IP?
guggero
suggested changes
Mar 5, 2021
There was a problem hiding this comment.
👍 for making this configurable. How about this: We change the config.Profile to a string and parse it. If it's just a number (e.g. to not break existing users that have the flag set), we use 127.0.0.1 as the host. If it's a host:port pair, use that directly.
Same for the other repos where this was proposed.
Misuwp
approved these changes
Jul 29, 2022
|
@Crypt-iQ, remember to re-request review from reviewers when ready |
1 task
|
Replaced by #391. |
positiveblue
pushed a commit
to positiveblue/pool
that referenced
this pull request
Oct 11, 2022
Reset conflict trackers periodically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, debugging information is exposed if the port is reachable.