Skip to content

Add C++ to build as test_cpp and fix errors. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 6, 2019

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Mar 6, 2019

I wasn't sure what to name it, so I went with test_cpp and set it to not be installed.

@evanmiller
Copy link
Collaborator

Hi, please fix the CI errors. You can also add test_cpp to check_PROGRAMS.

@QuLogic
Copy link
Contributor Author

QuLogic commented Mar 6, 2019

Where is export CC=clang set? I cannot find it, but it should also set CXX=clang++.

@evanmiller
Copy link
Collaborator

@QuLogic
Copy link
Contributor Author

QuLogic commented Mar 6, 2019

No, the export is done before calling bootstrap. I think the above change to Travis setting might do it...

@QuLogic
Copy link
Contributor Author

QuLogic commented Mar 6, 2019

I had to set it to require C++11, because the other headers seem to just be broken. This does require you to have autoconf-archive installed to run ./bootstrap, or we can copy the C++11 autoconf check into the source.

However, I have no idea what's wrong with clang on Ubuntu+Travis. It seems to just be broken.

@jennybc
Copy link
Contributor

jennybc commented Mar 6, 2019

I had to set it to require C++11

I may not be following all this, but this might be a pretty big deal for readxl.

@QuLogic
Copy link
Contributor Author

QuLogic commented Mar 6, 2019

readxl doesn't use any of the C++ files, and they are not required. It's merely a test program.

This seems to be mostly a workaround for the clang++ on Travis being
broken, as it works fine on other systems.
@QuLogic
Copy link
Contributor Author

QuLogic commented Mar 6, 2019

OK, finally it seems to be working. I don't know why Travis' clang is broken OOTB. It works fine in a Ubuntu Trusty docker container using distro-provided packages.

@evanmiller
Copy link
Collaborator

Thanks for all the work on this one!

@evanmiller evanmiller merged commit 59a88ee into libxls:master Mar 6, 2019
@QuLogic QuLogic deleted the cpp-build branch March 8, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants