-
Notifications
You must be signed in to change notification settings - Fork 138
Add C++ to build as test_cpp and fix errors. #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, please fix the CI errors. You can also add |
Where is |
Should be set by https://www.gnu.org/software/autoconf/manual/autoconf-2.66/html_node/C_002b_002b-Compiler.html |
No, the |
I had to set it to require C++11, because the other headers seem to just be broken. This does require you to have However, I have no idea what's wrong with |
I may not be following all this, but this might be a pretty big deal for readxl. |
|
This seems to be mostly a workaround for the clang++ on Travis being broken, as it works fine on other systems.
OK, finally it seems to be working. I don't know why Travis' clang is broken OOTB. It works fine in a Ubuntu Trusty docker container using distro-provided packages. |
Thanks for all the work on this one! |
I wasn't sure what to name it, so I went with
test_cpp
and set it to not be installed.