windows: don't mark with dllexport in static build #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pen7art
pushed a commit
to Pen7art/hidapi
that referenced
this pull request
Mar 15, 2025
* add prebuilds for arm64 * use prebuildify * fix workflow * fix workflow (again) * try again * remove accidentally committed prebuilds * add support for hidraw variants * fix hidraw only exists on linux * add prebuilds and *.tgz to .gitignore * replace readme badge * rename `BINDING_NAME_RAW` to `BINDING_NAME_HIDRAW` * re-enable tests * use options from `binding-options.js` * chore: update pkg-prebuilds * chore: update github actions workflow * run for prs * update workflow * fix alpine * fix alpine * fix alpine * update readme * trying pr 507 * Delete package.json.prebuildify argh I am so bad at github today * update github workflow * update actions * update publishing notes * fix: macos python 3.11 --------- Co-authored-by: Hannes Rüger <hannesrueger@gmx.de> Co-authored-by: Tod Kurt <todbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't mark API functions with
__declspec(dllexport)when building a static library on Windows.Enforced by CMake builds.
For other builds a compile definition is available.
Related: #480