-
Notifications
You must be signed in to change notification settings - Fork 588
build: unify source lists #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Jun 1, 2023
We repositioned crypto libs in 4f0f4bf via libssh2#941 and subsequently in d4f58f0 from d93ccf4 via libssh2#1013. This patch also moves libz accordingly, to unbreak certain build scenarios. Reported-by: Kenneth Davidson Fixes libssh2#1075 Closes #xxxx
vszakats
added a commit
that referenced
this pull request
Jun 1, 2023
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Jul 16, 2023
We repositioned crypto libs in 4f0f4bf via libssh2#941 and subsequently in d4f58f0 from d93ccf4 via libssh2#1013. This patch moves libz accordingly, to unbreak certain build scenarios. Reported-by: Kenneth Davidson Regression from 4f0f4bf libssh2#941 Fixes libssh2#1075 Closes libssh2#1077
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
- introduce `src/crypto.c` as an umbrella source that does nothing else than include the selected crypto backend source. Moving this job from the built-tool to the C preprocessor. - this allows dropping the various techniques to pick the correct crypto backend sources in autotools, CMake and other build method. Including the per-backend `Makefile.<crypto-backend>.inc` makefiles. - copy a trick from curl and instead of maintaining duplicate source lists for CMake, convert the GNU Makefile kept for autotools automatically. Do this in `docs`, `examples` and `src`. Ref: https://github.com/curl/curl/blob/dfabe8bca218d2524af052bd551aa87e13b8a10b/CMakeLists.txt#L1399-L1413 Also fixes missing `libssh2_setup.h` from `src/CMakeFiles.txt` after 59666e0. - move `Makefile.inc` from root to `src`. - reformat `src/Makefile.inc` to list each source in separate lines, re-align the continuation character and sort the lists alphabetically. - update `docs/HACKING-CRYPTO` accordingly. - autotools: update the way we add crypto-backends to `LIBS`. - delete old CSV headers, indent, and merge two lines in `docs/Makefile.am` and `src/Makefile.am`. - add `libssh2.pc` to `.gitignore`, while there. Closes libssh2#941
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
We repositioned crypto libs in 4f0f4bf via libssh2#941 and subsequently in d4f58f0 from d93ccf4 via libssh2#1013. This patch moves libz accordingly, to unbreak certain build scenarios. Reported-by: Kenneth Davidson Regression from 4f0f4bf libssh2#941 Fixes libssh2#1075 Closes libssh2#1077
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Mar 19, 2025
Instead build all crypto backend sources always, and exclude the inactive ones with guards. To play better with code checkers and compilers that are blind to included C sources, e.g. clang with certain compiler warnings and clang-tidy. Follow-up to 4f0f4bf libssh2#941
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Mar 19, 2025
Instead build all crypto backend sources always, and exclude the inactive ones with guards. To play better with code checkers and compilers that are blind to included C sources, e.g. clang with certain compiler warnings and clang-tidy. Follow-up to 4f0f4bf libssh2#941
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Mar 19, 2025
Instead build all crypto backend sources always, and exclude the inactive ones with guards. To play better with code checkers and compilers that are blind to included C sources, e.g. clang with certain compiler warnings and clang-tidy. We continue to include blowfish.c. Follow-up to 4f0f4bf libssh2#941
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Mar 21, 2025
Instead build all crypto backend sources always, and exclude the inactive ones with guards. To play better with code checkers and compilers that are blind to included C sources, e.g. clang with certain compiler warnings and clang-tidy. We continue to include blowfish.c. Follow-up to 4f0f4bf libssh2#941
vszakats
added a commit
that referenced
this pull request
Mar 24, 2025
Instead build all crypto backend sources always, and exclude inactive ones with guards. To play better with code checkers and compilers that are blind to included C sources, e.g. clang with certain compiler warnings and clang-tidy. We continue to include `blowfish.c`. Follow-up to 4f0f4bf #941 Cherry-picked from #1561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce
src/crypto.c
as an umbrella source that does nothing elsethan include the selected crypto backend source. Moving this job from
the built-tool to the C preprocessor.
this allows dropping the various techniques to pick the correct crypto backend
sources in autotools, CMake and other build method. Including the per-backend
Makefile.<crypto-backend>.inc
makefiles.copy a trick from curl and instead of maintaining duplicate source lists for CMake,
convert the GNU Makefile kept for autotools automatically. Do this in
docs
,examples
andsrc
.Ref: https://github.com/curl/curl/blob/dfabe8bca218d2524af052bd551aa87e13b8a10b/CMakeLists.txt#L1399-L1413
Also fixes missing
libssh2_setup.h
fromsrc/CMakeFiles.txt
after 59666e0.move
Makefile.inc
from root tosrc
.reformat
src/Makefile.inc
to list each source in separate lines, re-align thecontinuation character and sort the lists alphabetically.
update
docs/HACKING-CRYPTO
accordingly.autotools: update the way we add crypto-backends to
LIBS
.delete old CSV headers, indent, and merge two lines in
docs/Makefile.am
andsrc/Makefile.am
.add
libssh2.pc
to.gitignore
, while there.Closes #941