mbedtls: fail to compile with v3.6.0 outside CI #1393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A compile-time failure is preferred over an unexpected one at runtime. The problem is silenced with a macro in CI and this macro will have to be added to more platforms when mbedTLS v3.6.0 reaches them. Follow-up to 2e4c5ec libssh2#1349 Closes libssh2#1393
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Jul 13, 2024
vszakats
added a commit
that referenced
this pull request
Jul 13, 2024
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
A compile-time failure is preferred over an unexpected one at runtime. The problem is silenced with a macro in CI and this macro will have to be added to more platforms when mbedTLS v3.6.0 reaches them. Follow-up to 2e4c5ec libssh2#1349 Closes libssh2#1393
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
While it's moved to pk_internal, it won't removed in mbedTLS 3.6 LTS so it's safe to redeclare it on our side to find it. This is implementing emergency fix suggested from libssh2@2e4c5ec#commitcomment-141379351 Follow-up to e973493 libssh2#1393 Follow-up to 2e4c5ec libssh2#1349 Closes libssh2#1421
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compile-time failure is preferred over an unexpected one at
runtime.
The problem is silenced with a macro in CI and this macro will
have to be added to more platforms when mbedTLS v3.6.0
reaches them.
Follow-up to 2e4c5ec #1349
Closes #1393