ci: fix mbedtls runners on macOS #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, obviously I messed soemthing up there becasue it only ran two checks. Investigating… |
f1dec82 to
622ce6a
Compare
622ce6a to
c2c2b2f
Compare
|
Isn't this ultmately a bug in our configure scripts? |
|
It might be, but I also don't think this would affect normal macOS installations. I could be wrong here, but the issue appears to be that libz is only installed on /opt/homebrew on the runners, while most macOS installations also have it in /usr. But I definitely could be mistaken. |
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
May 8, 2024
Follow-up to 8441153 libssh2#1381 Closes libssh2#1382
|
Ah okay, if this is specific to the GHA runners, and not to regular macOS ARM + Homebrew installs, I agree we shouldn't chase it further. (Aside from possibly reporting it to GitHub.) |
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
May 8, 2024
Follow-up to 8441153 libssh2#1381 Closes libssh2#1382
|
I can try it on a clean macOS ARM install this evening and see if it works. |
vszakats
added a commit
that referenced
this pull request
May 8, 2024
autotools lib detection routine failed to extend LDFLAGS for each detection. This could cause successful detection of a dependency, but later failing to use it. This did not cause an issue as long as all dependencies lived under the same prefix, but started breaking on macOS ARM + Homebrew where this was no longer true for mbedTLS and zlib in particular. Follow-up to 8441153 #1381 Follow-up to ae2770d #1377 Closes #1384
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
Sets LDFLAGS while configuring the autoconf mbedTLS build for macOS.
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
Follow-up to 8441153 libssh2#1381 Closes libssh2#1382
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
autotools lib detection routine failed to extend LDFLAGS for each detection. This could cause successful detection of a dependency, but later failing to use it. This did not cause an issue as long as all dependencies lived under the same prefix, but started breaking on macOS ARM + Homebrew where this was no longer true for mbedTLS and zlib in particular. Follow-up to 8441153 libssh2#1381 Follow-up to ae2770d libssh2#1377 Closes libssh2#1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.