Skip to content

Conversation

MichaelBuckley
Copy link
Contributor

@MichaelBuckley MichaelBuckley commented May 3, 2024

Caught this while merging into Panic's libssh2 repo, but I probably missed it in code review earlier. My goal is to upstream all the changes from our repo, so more pull requests coming soon.

@MichaelBuckley
Copy link
Contributor Author

There's one failing CI check, but it was because the CI couldn't find zlib, which has nothing to do with my change.

@vszakats
Copy link
Member

vszakats commented May 5, 2024

There's one failing CI check, but it was because the CI couldn't find zlib, which has nothing to do with my change.

I can confirm. The mbedTLS detection (or something around it) no longer works since the runners got bumped to ARM.

If no one plans to work on this, we should probably disable this job. I didn't do it right to away to keep the issue visible (but an actual open Issue might serve this better).

Ref: ae2770d #1377

@MichaelBuckley
Copy link
Contributor Author

I'll see what I can do for this runner. It looks like it's just unable to find zlib.

@MichaelBuckley
Copy link
Contributor Author

Fixed it, broke three others, but I can break them into separate rules to make it work.

The core problem is that the configure script can't seem to handle it if we specify both --with-libmbedcrypto-prefix and --with-libz-prefix, so I had to set the LDFLAGS enviornment variable.

I'll make the fix in a new branch with a new pull request, once that passes, merge it, and then rebase this branch on top of that.

@MichaelBuckley
Copy link
Contributor Author

I'm just going to merge this one. It looks like the AppVeyor runners are tired from how many builds we've put them through today, but we know they passed on an earlier commit.

@MichaelBuckley MichaelBuckley merged commit 8b3c6e9 into libssh2:master May 8, 2024
@MichaelBuckley MichaelBuckley deleted the dsa-pubkey-fix branch May 8, 2024 20:44
@vszakats
Copy link
Member

vszakats commented May 8, 2024

No worries, this already finished green earlier.

AppVeyor is prone to fail when GHA jobs are queued up (or something). One GHA workflow is providing the server for the AppVeyor tests, and in such cases the server either doesn't come up online or sometimes dies while tests are still executing. It would be nice to stabilize it.

agreppin pushed a commit to agreppin/libssh2 that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants