transport: check ETM on remote end when receiving #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should check if encrypt-then-MAC feature is enabled in remote end's configuration. Closes libssh2#1331
|
/cc @palmin |
|
I don't have permission to merge PRs and my work with encode-then-mac lies so far back now that I don't feel confident reviewing the change even though it is small. Sorry |
|
This fix is correct and should be merged. |
vszakats
approved these changes
Mar 28, 2024
|
@palmin: No worries, thanks for your quick feedback! @willco007: Thanks! @malyzelenyhnus: Thanks for your patch, merged now. |
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
We should check if encrypt-then-MAC feature is enabled in remote end's configuration. Fixes libssh2#1331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should check if encrypt-then-MAC feature is enabled in remote end's configuration.
Closes #1331