Supply empty hash functions for mac_method_hmac_aesgcm to avoid a crash when e.g. setting LIBSSH2_METHOD_CRYPT_CS #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh when e.g. setting LIBSSH2_METHOD_CRYPT_CS
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
…sh when e.g. setting LIBSSH2_METHOD_CRYPT_CS (libssh2#1321)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mac_method_hmac_aesgcm currently sets its hash functions to NULL. This is typically fine, when both the local and remote session are using mac_method_hmac_aesgcm. But it's possible to set just one of the sessions to use e.g. aes128-ctr, and if you do that, the hash functions will get called without first checking if they're NULL or not.
This may be a misconfiguration which will prevent a proper connection, but it's better that libssh2 not defererence NULL in this circunstance.