ci/appveyor: re-enable parallel mode #1294
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
The comment cited earlier is no longer true with recent CMake versions. This options does actually enable parallel builds with MSVC since CMake v3.26.0: https://gitlab.kitware.com/cmake/cmake/-/issues/20564 The effect isn't much for libssh2, because it spends most time in tests, but let's enable it anyway for efficiency. Ref: 0d08974 libssh2#884 Ref: 7a039d9 libssh2#867 Closes libssh2#1294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment cited earlier is no longer true with recent CMake versions.
This options does actually enable parallel builds with MSVC since CMake
v3.26.0: https://gitlab.kitware.com/cmake/cmake/-/issues/20564
The effect isn't much for libssh2, because it spends most time in tests,
but let's enable it anyway for efficiency.
Ref: 0d08974 #884
Ref: 7a039d9 #867
Closes #1294