NMakefile: delete #1134
Closed
NMakefile: delete #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make file was for long time unmaintained (last update in 2014). Despite best efforts to keep it working in the recent round of major overhauls, it appears to be broken now. There is also no way to test it without an actual MSVC env and it's also missing from our CI. Based on our Issue tracker, it's also not widely used. Since its addition in 2005, libssh2 got support for CMake in 2014. CMake should be able to generate NMake makefiles with the option `-G "NMake Makefiles"`. (I haven't tested this.) Ref: libssh2#1129 Closes libssh2#1134
|
This brings down supported build systems to 5, of which 3 are generic, 2 are platform-specific: autotools, CMake, GNU Make + OS/400, VMS. |
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Sep 3, 2023
This make file was for long time unmaintained (last updated in 2014). Despite best efforts to keep it working in the recent round of major overhauls, it appears to be broken now. There is also no way to test it without an actual MSVC env and it's also missing from our CI. Based on our Issue tracker, it's also not widely used. Since its addition in 2005, libssh2 got support for CMake in 2014. CMake should be able to generate NMake makefiles with the option `-G "NMake Makefiles"`. (I haven't tested this.) Ref: libssh2#1129 Closes libssh2#1134
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
This make file was for long time unmaintained (last updated in 2014). Despite best efforts to keep it working in the recent round of major overhauls, it appears to be broken now. There is also no way to test it without an actual MSVC env and it's also missing from our CI. Based on our Issue tracker, it's also not widely used. Since its addition in 2005, libssh2 got support for CMake in 2014. CMake should be able to generate NMake makefiles with the option `-G "NMake Makefiles"`. (I haven't tested this.) Ref: libssh2#1129 Closes libssh2#1134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make file was for long time unmaintained (last updated in 2014).
Despite best efforts to keep it working in the recent round of major
overhauls, it appears to be broken now. There is also no way to test it
without an actual MSVC env and it's also missing from our CI. Based on
our Issue tracker, it's also not widely used.
Since its addition in 2005, libssh2 got support for CMake in 2014.
CMake should be able to generate NMake makefiles with the option
-G "NMake Makefiles". (I haven't tested this.)Ref: #1129
Closes #1134