hostkey: do not advertise ssh-rsa when SHA1 is disabled #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wincng and os400 backends would also need this change. Also, I don't think this is the actual issue in #1092. If sha2 was configured correctly on that server, |
Before this patch OpenSSL, mbedTLS, WinCNG and OS/400 advertised both SHA2 and SHA1 host key algos, even when SHA1 was not supported by the crypto backend or when forcefully disabled via `LIBSSH2_NO_RSA_SHA1`. Reported-by: João M. S. Silva Fixes libssh2#1092 Closes libssh2#1093
00a3512 to
61129ae
Compare
|
@willco007 Yes, it's strange; it'd be useful to understand what is happening there exactly. Thanks for the heads up about OS/400 and WinCNG, tackled those as well now with a force-push. |
|
This looks good regardless of if it fixes #1092 or not. |
|
According to #1092 (comment), this patch fixes #1092. |
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Jul 16, 2023
Before this patch OpenSSL, mbedTLS, WinCNG and OS/400 advertised both SHA2 and SHA1 host key algos, even when SHA1 was not supported by the crypto backend or when forcefully disabled via `LIBSSH2_NO_RSA_SHA1`. Reported-by: João M. S. Silva Fixes libssh2#1092 Closes libssh2#1093
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
Before this patch OpenSSL, mbedTLS, WinCNG and OS/400 advertised both SHA2 and SHA1 host key algos, even when SHA1 was not supported by the crypto backend or when forcefully disabled via `LIBSSH2_NO_RSA_SHA1`. Reported-by: João M. S. Silva Fixes libssh2#1092 Closes libssh2#1093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch OpenSSL and mbedTLS advertised both SHA2 and SHA1 host key algos, even when SHA1 was not supported by the crypto backend or forcefully disabled via
LIBSSH2_NO_RSA_SHA1.Reported-by: João M. S. Silva
Fixes #1092
Closes #1093