Skip to content

SPDX identifiers and a CI job to check them all #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

SPDX identifiers and a CI job to check them all #1084

merged 1 commit into from
Jun 7, 2023

Conversation

bagder
Copy link
Member

@bagder bagder commented Jun 5, 2023 •
edited
Loading

  • All files have prominent copyright and SPDX identifier
  • If not embedded in the file, in the .reuse/dep5 file
  • All used licenses are in LICENSES/ (not shipped in tarballs)
  • A new REUSE CI job verify that all files are OK

vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
@bagder

This comment was marked as outdated.

Sign in to view
@bagder

This comment was marked as outdated.

Sign in to view
@bagder bagder marked this pull request as ready for review June 5, 2023 17:56
@bagder bagder force-pushed the bagder/SPDX branch 2 times, most recently from 266e592 to 17438a1 Compare June 5, 2023 18:05
@bagder
Copy link
Member Author

bagder commented Jun 5, 2023

Ping @mxmehl anything obvious you can think of I might have missed here?

vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
vszakats
vszakats reviewed Jun 5, 2023
View reviewed changes
bagder added a commit that referenced this pull request Jun 6, 2023
@bagder
provide SPDX identifiers
7e0f61a 
- All files have prominent copyright and SPDX identifier
- If not embedded in the file, in the .reuse/dep5 file
- All used licenses are in LICENSES/ (not shipped in tarballs)
- A new REUSE CI job verify that all files are OK

Assisted-by: Viktor Szakats

Closes #1084
@bagder
provide SPDX identifiers
4be6cd5 
- All files have prominent copyright and SPDX identifier
- If not embedded in the file, in the .reuse/dep5 file
- All used licenses are in LICENSES/ (not shipped in tarballs)
- A new REUSE CI job verify that all files are OK

Assisted-by: Viktor Szakats

Closes #1084
@bagder bagder merged commit f6aa31f into master Jun 7, 2023
@bagder bagder deleted the bagder/SPDX branch June 7, 2023 06:18
@mxmehl
Copy link

mxmehl commented Jun 13, 2023

Ping @mxmehl anything obvious you can think of I might have missed here?

Sorry, I was on vacation. But it looks like you did a great job. Thank you!

The cherry on the top would be to register the repository with the REUSE API and include the resulting "compliant" badge e.g. in the README file. curl is also registered though I'm not sure whether it was @bagder who did it.

@bagder
Copy link
Member Author

bagder commented Jun 13, 2023

Thanks @mxmehl. I've registered this project there now and also @c-ares which was also made compliant a few days ago.

@mxmehl
Copy link

mxmehl commented Jun 13, 2023

Excellent! A check by the API will be triggered once there is a new commit on the main branch and if someone requests the badge.

The API does not check pro-actively for new commits (yet), so including the badge in the README file ensures that the API has the latest information on REUSE compliance.

@bagder
Copy link
Member Author

bagder commented Jun 13, 2023

I'm not fan of badges, so none of these three projects get that. For the moment at least.

@vszakats
Copy link
Member

vszakats commented Jun 21, 2023 •
edited
Loading

After a REUSE spec and checker tool update (upstream) an hour ago, we got two new failures: #1101

UPDATE: Fixed in #1102

lampmanyao pushed a commit to lampmanyao/libssh2 that referenced this pull request Jul 16, 2023
@bagder @lampmanyao
provide SPDX identifiers
d50d752 
- All files have prominent copyright and SPDX identifier
- If not embedded in the file, in the .reuse/dep5 file
- All used licenses are in LICENSES/ (not shipped in tarballs)
- A new REUSE CI job verify that all files are OK

Assisted-by: Viktor Szakats

Closes libssh2#1084
agreppin pushed a commit to agreppin/libssh2 that referenced this pull request Jul 14, 2024
@bagder @agreppin
provide SPDX identifiers
9d620db 
- All files have prominent copyright and SPDX identifier
- If not embedded in the file, in the .reuse/dep5 file
- All used licenses are in LICENSES/ (not shipped in tarballs)
- A new REUSE CI job verify that all files are OK

Assisted-by: Viktor Szakats

Closes libssh2#1084
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vszakats vszakats vszakats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bagder @mxmehl @vszakats