autotools: skip tests requiring static lib if --disable-static
#1072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81bae52 to
59cfd30
Compare
--disable-static
--disable-static--disable-static
6b4302f to
47b076f
Compare
- rename RUN_TESTS_WITH_LIB_STATIC to HAVE_LIB_STATIC - shorten suffix _WITH_LIB_STATIC to _STATIC - drop existing TESTS_WITH_LIB_STATIC variable now with a duplicate of exceptions and use the new lists in CMakeLists.txt and Makefile.mk. Also fixing the latter to not lose static tests. - fix CMake builds to keep running static tests. - restore and update comment in Makefile.inc - update variable lists in comments
47b076f to
3990ff3
Compare
|
Thank you! Merged now. |
vszakats
added a commit
that referenced
this pull request
May 31, 2023
Add a non-static autotools build to GitHub Actions. Make this build target i386 and libgcrypt, to test a new build combination if we are at it. Also: - GHA: add necessary generic bits for i386 autotools builds. - AppVeyor CI: teach it to ignore commits updating our GHA config. Follow-up to 572c57c #1072 Closes #1074
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Jul 16, 2023
…ssh2#1072) Co-authored-by: Viktor Szakats Regression from 83853f8 libssh2#663 Fixes libssh2#1056
lampmanyao
pushed a commit
to lampmanyao/libssh2
that referenced
this pull request
Jul 16, 2023
Add a non-static autotools build to GitHub Actions. Make this build target i386 and libgcrypt, to test a new build combination if we are at it. Also: - GHA: add necessary generic bits for i386 autotools builds. - AppVeyor CI: teach it to ignore commits updating our GHA config. Follow-up to 572c57c libssh2#1072 Closes libssh2#1074
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
…ssh2#1072) Co-authored-by: Viktor Szakats Regression from 83853f8 libssh2#663 Fixes libssh2#1056
agreppin
pushed a commit
to agreppin/libssh2
that referenced
this pull request
Jul 14, 2024
Add a non-static autotools build to GitHub Actions. Make this build target i386 and libgcrypt, to test a new build combination if we are at it. Also: - GHA: add necessary generic bits for i386 autotools builds. - AppVeyor CI: teach it to ignore commits updating our GHA config. Follow-up to 572c57c libssh2#1072 Closes libssh2#1074
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Viktor Szakats
Regression from 83853f8 #663
Fixes #1056