ci/appveyor: reduce test runs (workaround for infrastructure permafails) #1461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb7e54b to
609094f
Compare
|
Are the docker bridge containers CI jobs actually launched on GitHub in time? |
|
It seemed to me they do launch, then remain idle. But my idea of "in time" is fuzzy and may be misinterpreting the visible logs. |
Jobs consistently fail to connect to the test server (run in GHA) since 2024-Aug-29: https://ci.appveyor.com/project/libssh2org/libssh2/builds/50498393 There was an earlier phase of failures one month before that, that got fixed by increasing the wait for the server in bf3af90. Let's make that wait 10 minues (was 5), in case it helps, though I tried it earlier to no avail. Such long wait doesn't seem acceptable if it works, and a sign of issues lurking somewhere. Thus, skip running tests in AppVeyor CI. This leaves the Windows platform with no tests at all. Except in the last job to serve as a canary in case the tests would "fix themselves", and to leave a signal that we have problem.
This reverts commit 460c45b.
2f6f5cd to
f97a7da
Compare
|
After some trial and error it seems that if the last OpenSSL and last WinCrypt job are enabled, they both finish fine. No idea what the logic is behind this, if any, or if this will stay this way or just a fluke. |
|
Merged. This PR is not a solution to this problem, just an attempt to keep the CI usable till a real fix is found and we can re-enable tests for these Windows CI jobs. |
vszakats
added a commit
to vszakats/libssh2
that referenced
this pull request
Oct 4, 2024
Follow-up to b5e68bd libssh2#1461 Closes libssh2#1468
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs consistently fail to connect to the test server (run in GHA) since
2024-Aug-29:
https://ci.appveyor.com/project/libssh2org/libssh2/builds/50498393
There was an earlier phase of failures one month before that, that got
fixed by increasing the wait for the server in
bf3af90.
Thus, skip running tests in AppVeyor CI jobs, except: After some
experiments, it seems that running tests with the last OpenSSL job and
the last WinCrypt job work, which still leaves some coverage.
It remains to be seen how stable this is.
This is meant as a temporary fix till there is a solution to make all
jobs run tests reliable like up until a few months ago.
Bumping up the timeout to 10 minutes doesn't help. But it turns out
by accident, that running the tests only in the last AppVeyor job does
pick up the server and run correctly. So it's not serving as a "canary"
or a signal after all.