Skip to content

Fix CMake shared library ABI version on Apple platforms #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2021
Merged

Fix CMake shared library ABI version on Apple platforms #743

merged 1 commit into from
May 16, 2021

Conversation

evpobr
Copy link
Member

@evpobr evpobr commented May 16, 2021

Now ABI version must be compatible with Autotools builds. Note that this change requires CMake >= 3.17 for building dylib on Apple platforms.

@evpobr
cmake: Fix shared library ABI on Apple platforms
0cbfc93 
Now ABI version must be compatible with Autotools builds. Note that
this change requires CMake >= 3.17 for building dylib on Apple
platforms.
@evpobr evpobr linked an issue May 16, 2021 that may be closed by this pull request
Package should lie about its macOS compatibility version like original upstream did #742
Closed
@evpobr evpobr requested a review from SoapGentoo May 16, 2021 09:56
@evpobr
Copy link
Member Author

evpobr commented May 16, 2021

@SoapGentoo , do you have the opportunity to test this on macOS?

@SoapGentoo
Copy link
Member

master:
@rpath/libsndfile.1.dylib (compatibility version 1.0.0, current version 1.0.31)
fix-cmake-apple-platform-dylib-abi:
@rpath/libsndfile.1.dylib (compatibility version 2.0.0, current version 2.31.0)

@evpobr evpobr merged commit 0cbfc93 into master May 16, 2021
@evpobr evpobr deleted the fix-cmake-apple-platform-dylib-abi branch May 16, 2021 12:26
@thesamesam thesamesam mentioned this pull request Mar 7, 2022
Closed
@evpobr
Copy link
Member Author

evpobr commented Mar 7, 2022

@SoapGentoo , any ideas about libexpat/libexpat#55?

@SoapGentoo
Copy link
Member

I still believe fundamentally that trying to make libtool and CMake bug-compatible is a lost cause. We should realyl work towards getting rid of Autotools.

@hartwork hartwork mentioned this pull request Mar 7, 2022
Closed
@hartwork
Copy link

hartwork commented Mar 7, 2022

@SoapGentoo for Expat, it should be noted that getting rid of Autotools means a circular dependency loop CMake -> Expat -> CMake. At least for Expat, Autotools is not likely to go away.

@SoapGentoo
Copy link
Member

I get that, and expat is a bit special in this regard, something libsndfile doesn't have.

@hartwork
Copy link

hartwork commented Mar 7, 2022

@SoapGentoo nevermind, I was not intending to speak for cases other than Expat 👍

@hebasto hebasto mentioned this pull request Apr 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoapGentoo SoapGentoo SoapGentoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package should lie about its macOS compatibility version like original upstream did
3 participants
@evpobr @SoapGentoo @hartwork