Skip to content

add build_tests option #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2022
Merged

add build_tests option #84

merged 1 commit into from
Nov 7, 2022

Conversation

ffontaine
Copy link
Contributor

Allow the user to disable build of test programs

Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com

@ffontaine
add build_tests option
94d6d6f 
Allow the user to disable build of test programs

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
@kjellahl kjellahl merged commit dc2f2f4 into libsigcplusplus:master Nov 7, 2022
kjellahl added a commit that referenced this pull request Nov 7, 2022
@kjellahl
Meson build: Always call subdir('tests')
9ccf75f 
Make the build_tests check more like the check in cairomm and libxml++.
Then it's possible to combine build-tests=false with benchmark=true.
See PR #84
@kjellahl
Copy link
Contributor

kjellahl commented Nov 7, 2022

I've merged this PR and added a commit that makes the build_tests check more like the
check in cairomm and libxml++. I've copied the two commits to the libsigc++-2-12 branch.

@ffontaine
Copy link
Contributor Author

In my first iteration, I tried to set build_by_default as done by commit 5711e2b but for an unknown reason, it wasn't working (the tests were always built). I'll double check on master.

@kjellahl
Copy link
Contributor

kjellahl commented Nov 7, 2022

Did you put if build_tests around test(ex_name, exe_file)?

  # If exe_file is a test program, it is built by default unconditionally.
  if build_tests
    test(ex_name, exe_file)
  endif

@ffontaine
Copy link
Contributor Author

Nope, I only updated build_by_default, thanks for your answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffontaine @kjellahl